Fix crash caused UserAccountManager dependency not being injected#4111
Merged
AndyScherzinger merged 1 commit intoJun 3, 2019
Merged
Conversation
Fixes #4107 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii
force-pushed
the
ezaquarii/fix-crash-in-text-preview-fragment
branch
from
32bc73e to
30af6a9
Compare
Collaborator
Author
|
@tobiasKaminsky @AndyScherzinger I think this should be merged ASAP. |
ezaquarii
commented
Jun 2, 2019
| import androidx.core.view.MenuItemCompat; | ||
|
|
||
| public class PreviewTextFragment extends FileFragment implements SearchView.OnQueryTextListener { | ||
| public class PreviewTextFragment extends FileFragment implements SearchView.OnQueryTextListener, Injectable { |
Collaborator
Author
There was a problem hiding this comment.
Missing Injectable caused the user account to be null and - surprise, surprise - NPE.
To test this code path just try opening any txt file. It should not crash.
AndyScherzinger
approved these changes
Jun 2, 2019
Collaborator
Author
|
It looks like emulator died. There is no chance this fix causes a build failure. Restarting... |
Collaborator
Author
|
Build fails again, despite no errors in log. |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9603.apk |
Collaborator
Codacy310Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #4111 +/- ##
============================================
- Coverage 12.81% 12.77% -0.05%
Complexity 1 1
============================================
Files 332 332
Lines 31068 31068
Branches 4431 4431
============================================
- Hits 3981 3968 -13
- Misses 26413 26430 +17
+ Partials 674 670 -4
|
Member
|
Latest build worked 👍 |
|
Yeah, worked also here ... |
tobiasKaminsky
added a commit
that referenced
this pull request
Jun 4, 2019
Member
|
Thank you @ezaquarii for finding the cause and also directly provide a PR ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Narkiewicz hello@ezaquarii.com
Resolves #4107